Merge pull request #1072 from DaanRademaker/fix_typo_volume_permissions

fix privilidge typo in volume permissions
godatadriven · Dec 9, 2024 · a7abf0d · a7abf0d
2 parents 28012bb + 02ad3bf
commit a7abf0d
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/aws-lambda/src/databricks_cdk/resources/permissions/volume_permissions.py b/aws-lambda/src/databricks_cdk/resources/permissions/volume_permissions.py
@@ -29,7 +29,9 @@ def create_or_update_volume_permissions(
     permission_changes = get_permission_changes(existing_grants, properties.privilege_assignments)
 
     workspace_client.grants.update(
-        securable_type=SecurableType.VOLUME, full_name=properties.volume_name, changes=permission_changes
+        securable_type=SecurableType.VOLUME,
+        full_name=properties.volume_name,
+        changes=permission_changes,
     )
 
     return CnfResponse(
@@ -47,7 +49,9 @@ def delete_volume_permissions(properties: VolumePermissionsProperties, physical_
     permission_changes = get_permission_changes(existing_grants, [])
 
     workspace_client.grants.update(
-        securable_type=SecurableType.VOLUME, full_name=properties.volume_name, changes=permission_changes
+        securable_type=SecurableType.VOLUME,
+        full_name=properties.volume_name,
+        changes=permission_changes,
     )
 
     return CnfResponse(

diff --git a/typescript/src/resources/permissions/volumePermissions.ts b/typescript/src/resources/permissions/volumePermissions.ts
@@ -10,7 +10,7 @@ export enum PrivilegeVolume {
 
 export interface PrivilegeAssignmentVolume {
     principal: string
-    priviliges: Array<PrivilegeVolume>
+    privileges: Array<PrivilegeVolume>
 }
 
 export interface VolumePermissionsProperties {

diff --git a/typescript/tests/resources/permissions/volumePermissions.test.ts b/typescript/tests/resources/permissions/volumePermissions.test.ts
@@ -13,7 +13,7 @@ describe("VolumePermissions", () => {
             privilege_assignments: [
                 {
                     principal: "some-principal",
-                    priviliges: [
+                    privileges: [
                         PrivilegeVolume.APPLY_TAG,
                         PrivilegeVolume.READ_VOLUME,
                         PrivilegeVolume.WRITE_VOLUME,
@@ -22,7 +22,7 @@ describe("VolumePermissions", () => {
                 },
                 {
                     principal: "some-other-principal",
-                    priviliges: [
+                    privileges: [
                         PrivilegeVolume.APPLY_TAG,
                         PrivilegeVolume.READ_VOLUME,
                     ]
@@ -46,7 +46,7 @@ describe("VolumePermissions", () => {
                 "privilege_assignments": [
                     {
                         "principal": "some-principal",
-                        "priviliges": [
+                        "privileges": [
                             "APPLY_TAG",
                             "READ_VOLUME",
                             "WRITE_VOLUME",
@@ -55,7 +55,7 @@ describe("VolumePermissions", () => {
                     },
                     {
                         "principal": "some-other-principal",
-                        "priviliges": [
+                        "privileges": [
                             "APPLY_TAG",
                             "READ_VOLUME"
                         ]