-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add only diff run flag #215
Conversation
Hello and thanks for the PR. We'll do a review ASAP. In the mean time can you pleas check the failing CI checks? |
Hi! Yes, of course. I just want to get approve of solution design. Is it good for you? |
Fixed. But I need advice about
|
@k3rn31 Hi! I'm thinking about adding this to my work projects. How much time will a review take? If it's not long I'll wait for a merge. |
Hi! we're doing the review today, it looks promising (except for one Codeclimate linting error). I believe I'll merge soon on develop, but I'm not sure when we'll make a new release. This is a good change we'll make an extra release earlier to let this feature available right away. |
Ok, thanks!
About that. I want be in sync with your vision and wanna know a way that you prefer:
|
I think the struct param is better, since we don't use it as a library and the option doesn't make sense to me. |
Codeclimate issue
I combined a coverage and diff into CodeData. So it can be extended in future for solving #167 Let me know if you want to rename it or squash/rename some commits. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
- Coverage 88.57% 88.02% -0.56%
==========================================
Files 18 20 +2
Lines 1322 1394 +72
==========================================
+ Hits 1171 1227 +56
- Misses 126 141 +15
- Partials 25 26 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think your implementation is sound.
I would have taken a slightly different approach: instead of marking a mutator as "skipped", you could mark it as runnable or not (if the diff flag is active) in the same spot where it checks if it has coverage. This way no changes would have been necessary in the executor.
Proposed changes
Running mutations only for changes. A new flag
diff
runsgit diff
with reference and skip mutants outside of changes.Look at docs change for details.
Types of changes
Checklist
make all
)Further comments