Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[update] bindplan sticked with a columnfilter #326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hsinhoyeh
Copy link

This patch sticked a updatePlan to a column filter. So if you used two different column filters for update, it will store two updatePlan into DbMap. But that would be a problem to your design if you use thousands of column filters, which is unlikely happened.

Reason: when updating specific columns of a table, the current approach sticks all column filters to a single bindPlan, which makes it only work for the first one. However, generating updatePlan on-the-fly sounds inefficient, instead sticking a column filter to it's own updatePlan sounds like a good trade-off.

related issues: #308, #325

@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 67.093% when pulling 9e3b102 on hsinhoyeh:master into 88f3ff2 on go-gorp:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants