[update] bindplan sticked with a columnfilter #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch sticked a updatePlan to a column filter. So if you used two different column filters for update, it will store two updatePlan into DbMap. But that would be a problem to your design if you use thousands of column filters, which is unlikely happened.
Reason: when updating specific columns of a table, the current approach sticks all column filters to a single bindPlan, which makes it only work for the first one. However, generating updatePlan on-the-fly sounds inefficient, instead sticking a column filter to it's own updatePlan sounds like a good trade-off.
related issues: #308, #325