Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split org Propfile README to a new tab overview #31373

Merged
merged 27 commits into from
Aug 27, 2024

Conversation

a1012112796
Copy link
Member

like user profile, add a new overviw tab to show profile READEME when it is exist.

replace #31349 (another solution option)

example view:
屏幕截图 2024-06-14 094116
屏幕截图 2024-06-14 094101

like user profile, add a new overviw tab
to show profile READEME when it is exist.

Signed-off-by: a1012112796 <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 14, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 14, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jun 14, 2024
@a1012112796 a1012112796 added the type/proposal The new feature has not been accepted yet but needs to be discussed first. label Jun 14, 2024
@a1012112796 a1012112796 changed the title proposal: split Propfile README to a new tab overview proposal: split org Propfile README to a new tab overview Jun 14, 2024
@lunny
Copy link
Member

lunny commented Jun 14, 2024

Looks like Github's default page is repositories list.

@silverwind
Copy link
Member

Github renders:

  • Overview tab: Readme + Repos
  • Repos tab: Repos

I suggest we do the same, which should make everyone happy.

@silverwind
Copy link
Member

Looks like Github's default page is repositories list.

No, if I open https://github.com/go-gitea, it goes to the the overview tab.

@a1012112796
Copy link
Member Author

Github renders:

  • Overview tab: Readme + Repos
  • Repos tab: Repos

I suggest we do the same, which should make everyone happy.

has add it 990584f

{{svg "octicon-info"}} {{ctx.Locale.Tr "user.overview"}}
</a>
{{end}}
<a class="{{if .PageIsViewRepositories}}active {{end}}item" href="{{$.Org.HomeLink}}{{if .HasProfileReadme}}?view_repositorys=true{{end}}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this route /<orgname>/repositories please? Query string is ugly and your view_repositorys is actually a typo.

@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 18, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 19, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 18, 2024
@lunny
Copy link
Member

lunny commented Aug 18, 2024

This is not ideal because I think the members and team on the right sidebar of repository list can be removed since there is an overview tab. Of course, it can be finished by another PR. But there is a conflict if there is no .profile repository.

@lunny lunny added this to the 1.23.0 milestone Aug 18, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 18, 2024
@wolfogre
Copy link
Member

This PR has been in reviewed/wait-merge status for long enough. I think it's time to merge.

@wolfogre wolfogre changed the title proposal: split org Propfile README to a new tab overview Split org Propfile README to a new tab overview Aug 27, 2024
@wolfogre wolfogre merged commit 39d2fde into go-gitea:main Aug 27, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 27, 2024
@a1012112796 a1012112796 deleted the zzc/dev/org_profile_2 branch August 27, 2024 03:48
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 27, 2024
* giteaofficial/main:
  Split org Propfile README to a new tab `overview` (go-gitea#31373)
  [skip ci] Updated translations via Crowdin
  Introduce globallock as distributed locks (go-gitea#31908)
william-allspice pushed a commit to william-allspice/gitea that referenced this pull request Aug 28, 2024
like user profile, add a new overviw tab to show profile READEME when it
is exist.

replace go-gitea#31349 (another solution option)

example view:
![屏幕截图 2024-06-14
094116](https://github.com/go-gitea/gitea/assets/25342410/3303a1f2-ae02-48e0-9519-7fa11e65657f)
![屏幕截图 2024-06-14
094101](https://github.com/go-gitea/gitea/assets/25342410/7a4a5a48-dc2b-4ad4-b2a2-9ea4ab5d5808)

---------

Signed-off-by: a1012112796 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants