Support using label names when changing issue labels #30943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
modifies/api
lunny
approved these changes
May 11, 2024
GiteaBot
added
lgtm/need 1
kemzeb
reviewed
May 11, 2024
kemzeb
approved these changes
May 13, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
wolfogre
approved these changes
May 13, 2024
| case reflect.Float64: | ||
| labelIDs = append(labelIDs, int64(rv.Float())) | ||
| case reflect.String: | ||
| labelNames = append(labelNames, rv.String()) |
There was a problem hiding this comment.
Maybe we should handle the default case for strange input like [[1]].
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
May 13, 2024
Resolve go-gitea#30917 Make the APIs for adding labels and replacing labels support both label IDs and label names so the [`actions/labeler`](https://github.com/actions/labeler) action can work in Gitea. <img width="600px" src="https://github.com/go-gitea/gitea/assets/15528715/7835c771-f637-4c57-9ce5-e4fbf56fa0d3" />
GiteaBot
added
backport/done
lunny
pushed a commit
that referenced
this pull request
May 13, 2024
Backport #30943 by @Zettat123 Resolve #30917 Make the APIs for adding labels and replacing labels support both label IDs and label names so the [`actions/labeler`](https://github.com/actions/labeler) action can work in Gitea. <img width="600px" src="https://github.com/go-gitea/gitea/assets/15528715/7835c771-f637-4c57-9ce5-e4fbf56fa0d3" /> Co-authored-by: Zettat123 <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 14, 2024
* giteaofficial/main: Protected tag is no internal server error (go-gitea#30962) [skip ci] Updated translations via Crowdin Restyle release list, fix branch dropdown (go-gitea#30837) fix: change npm scope registry (go-gitea#30964) Support using label names when changing issue labels (go-gitea#30943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #30917
Make the APIs for adding labels and replacing labels support both label IDs and label names so the
actions/labeleraction can work in Gitea.