Add project column choice option on issue sidebar #30617
Conversation
Signed-off-by: a1012112796 <[email protected]>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
github-actions
bot
added
modifies/translation
modifies/go
Signed-off-by: a1012112796 <[email protected]>
|
A change comment need to be created when switching successfully. |
That's another feature which is out of the topic of current pull request... |
Signed-off-by: a1012112796 <[email protected]>
No, I don't think so. It should be created with the same database transaction. |
see #30703, it's not a small change like what you see... |
|
Considering multi project support, maybe using modal later is a good choice. |
|
Please resolve the conflicts, sorry the rename PR results in conflicts. |
…_option Signed-off-by: a1012112796 <[email protected]>
Signed-off-by: a1012112796 <[email protected]>
Signed-off-by: a1012112796 <[email protected]>
Signed-off-by: a1012112796 <[email protected]>
Signed-off-by: a1012112796 <[email protected]>
lunny
changed the title
| @@ -28,6 +28,25 @@ func (issue *Issue) LoadProject(ctx context.Context) (err error) { | |||
| return err | |||
| } | |||
|
|
|||
| func (issue *Issue) LoadProjectIssue(ctx context.Context) (err error) { | |||
| @@ -58,17 +58,17 @@ func (Column) TableName() string { | |||
| } | |||
|
|
|||
| // NumIssues return counter of all issues assigned to the column | |||
| func (c *Column) NumIssues(ctx context.Context) int { | |||
| func (c *Column) NumIssues(ctx context.Context) (int64, error) { | |||
There was a problem hiding this comment.
The function is used by template/projects/view.tmpl, you need also to change that place.
| } | ||
| defer committer.Close() | ||
|
|
||
| num, err := toColumn.NumIssues(ctx) |
There was a problem hiding this comment.
This is not right. If you update two columns, then they will have the same sorting.
example:
