Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix actions when tagging #28061

Merged
merged 6 commits into from
Nov 25, 2023
Merged

Fix actions when tagging #28061

merged 6 commits into from
Nov 25, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 15, 2023 •
edited by 6543
Loading

close #28053

@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 15, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2023
@6543 6543 added type/bug topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Nov 15, 2023
6543
6543 reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@6543 6543 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not use current default?

it's outdated :D

.github/workflows/release-tag-version.yml Outdated Show resolved Hide resolved
.github/workflows/release-tag-rc.yml Outdated Show resolved Hide resolved
6543
6543 reviewed Nov 15, 2023
View reviewed changes
.github/workflows/release-tag-rc.yml Outdated Show resolved Hide resolved
.github/workflows/release-tag-version.yml Outdated Show resolved Hide resolved
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2023
@pull-request-size pull-request-size bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 15, 2023
@6543
Copy link
Member

6543 commented Nov 15, 2023

pipeline lint issue ...

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 15, 2023
@lunny lunny added the backport/v1.21 This PR should be backported to Gitea 1.21 label Nov 15, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 25, 2023
@techknowlogick techknowlogick merged commit 763938e into go-gitea:main Nov 25, 2023
1 of 2 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Nov 25, 2023
@GiteaBot GiteaBot mentioned this pull request Nov 25, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 25, 2023
@lunny @techknowlogick @GiteaBot
Fix actions when tagging (go-gitea#28061)
9116bc5 
close go-gitea#28053

---------

Co-authored-by: techknowlogick <[email protected]>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 25, 2023
techknowlogick added a commit that referenced this pull request Nov 25, 2023
@GiteaBot @lunny @techknowlogick
Fix actions when tagging (#28061) (#28218)
7f81110 
Backport #28061 by @lunny

close #28053

Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@lunny lunny deleted the lunny/release_tag_gh branch November 26, 2023 00:35
zjjhot added a commit to zjjhot/gitea that referenced this pull request Nov 27, 2023
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
b5c792f 
* giteaofficial/main:
  Fix actions when tagging (go-gitea#28061)
  Fix comment permissions (go-gitea#28213)
  Docs: Replace deprecated IS_TLS_ENABLED mailer setting in email setup (go-gitea#28205)
  Fix delete-orphaned-repos (go-gitea#28200)
  Refactor graceful manager to use shared code (go-gitea#28073)
  Fix some incorrect links in docs (go-gitea#28191)
  Remove workaround in disk-clean.yml (go-gitea#28195)
fuxiaohei pushed a commit to fuxiaohei/gitea that referenced this pull request Jan 17, 2024
@lunny @techknowlogick @fuxiaohei
Fix actions when tagging (go-gitea#28061)
c23501c 
close go-gitea#28053

---------

Co-authored-by: techknowlogick <[email protected]>
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@lunny @techknowlogick @silverwind
Fix actions when tagging (go-gitea#28061)
17aecf8 
close go-gitea#28053

---------

Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 left review comments

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/internal size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.

make sure gh binary exists
4 participants
@lunny @6543 @techknowlogick @GiteaBot