Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix data race when job stopped due to LimitRunsTo #540

Merged
merged 2 commits into from
Aug 17, 2023
Merged

fix data race when job stopped due to LimitRunsTo #540

merged 2 commits into from
Aug 17, 2023

Conversation

ryanrazsa
Copy link

What does this do?

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

Have you included tests for your changes?

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

@ryanrazsa ryanrazsa marked this pull request as ready for review August 16, 2023 22:09
@ryanrazsa ryanrazsa mentioned this pull request Aug 16, 2023
Closed
@JohnRoesler
Copy link
Contributor

Nice! Thanks for the fix

@JohnRoesler JohnRoesler merged commit b852750 into go-co-op:main Aug 17, 2023
6 checks passed
@JohnRoesler JohnRoesler changed the title Possible data race fix fix data race when job stopped due to LimitRunsTo Aug 17, 2023
@ryanrazsa ryanrazsa deleted the ryanrazsa/data_race_fix branch December 5, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnRoesler JohnRoesler JohnRoesler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanrazsa @JohnRoesler