remove by id should take job as id is private

go-co-op · Aug 20, 2023 · 27c9ecb · 27c9ecb
1 parent 92efff5
commit 27c9ecb
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/example_test.go b/example_test.go
@@ -659,6 +659,18 @@ func ExampleScheduler_Remove() {
 	// 0
 }
 
+func ExampleScheduler_RemoveByID() {
+	s := gocron.NewScheduler(time.UTC)
+
+	j, _ := s.Every(1).Week().Do(task)
+	_, _ = s.Every(1).Week().Do(task)
+	s.StartAsync()
+	s.RemoveByID(j)
+	fmt.Println(s.Len())
+	// Output:
+	// 1
+}
+
 func ExampleScheduler_RemoveByReference() {
 	s := gocron.NewScheduler(time.UTC)
 

diff --git a/scheduler.go b/scheduler.go
@@ -766,9 +766,9 @@ func (s *Scheduler) RemoveByTagsAny(tags ...string) error {
 }
 
 // RemoveByID removes the job from the scheduler looking up by id
-func (s *Scheduler) RemoveByID(id uuid.UUID) error {
-	if _, ok := s.Jobs()[id]; ok {
-		delete(s.Jobs(), id)
+func (s *Scheduler) RemoveByID(job *Job) error {
+	if _, ok := s.Jobs()[job.id]; ok {
+		delete(s.Jobs(), job.id)
 		return nil
 	}
 	return ErrJobNotFound