Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build system uglienesses and broken make LIBS="-lasan" #4194

Open
wants to merge 4 commits into
base: release-11
Choose a base branch
from

Conversation

jengelh
Copy link
Contributor

@jengelh jengelh commented Jul 5, 2023

No description provided.

@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

@gluster-ant
Copy link
Collaborator

Can one of the admins verify this patch?

Copy link

stale bot commented Mar 17, 2024

Thank you for your contributions.
Noticed that this issue is not having any activity in last ~6 months! We are marking this issue as stale because it has not had recent activity.
It will be closed in 2 weeks if no one responds with a comment here.

@stale stale bot added the wontfix Managed by stale[bot] label Mar 17, 2024
jengelh added 4 commits March 20, 2024 12:04
Automake has an implicit x = @x@ for every AC_SUBST-ed variable already,
stop reinventing the variables -- and enable standard make-time variable
overrides.

Signed-off-by: Jan Engelhardt <[email protected]>
Why the heck are -lcurlpp -lcryptopp in AM_CPPFLAGS? That variable is not getting
used during link anyway, and because of that, there is also no error emitted that
I do not have them installed in my OS.

Signed-off-by: Jan Engelhardt <[email protected]>
-l must go to LIBADD. Not CFLAGS. And definitely not CPPFLAGS.
It's not a preprocessor flag, darn it.
-I should preferably go into CPPFLAGS.

Signed-off-by: Jan Engelhardt <[email protected]>
Stop trampling on user-defined variables.
Move detected required libraries to their own specific variables.
Another benefit is that components which do not need one or more of
(-lcrypto, -lpthread, -lrt) are not forcibly linked to them.

./configure CFLAGS="-O0 -ggdb3 -fsanitize=address,undefined" &&
make -j16 LIBS="-lasan -lubsan"

Signed-off-by: Jan Engelhardt <[email protected]>
@stale stale bot removed the wontfix Managed by stale[bot] label Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants