Removed redundant log messages

If the details already available as API response, additional logging for success is removed. Signed-off-by: Aravinda VK <[email protected]>
gluster · Jan 4, 2019 · 0839909 · 0839909
1 parent 5dd1254
commit 0839909
Show file tree

Hide file tree

Showing 6 changed files with 0 additions and 7 deletions.
diff --git a/glusterd2/commands/volumes/volume-delete.go b/glusterd2/commands/volumes/volume-delete.go
@@ -103,7 +103,6 @@ func volumeDeleteHandler(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	logger.WithField("volume-name", volinfo.Name).Info("volume deleted")
 	events.Broadcast(volume.NewEvent(volume.EventVolumeDeleted, volinfo))
 
 	restutils.SendHTTPResponse(ctx, w, http.StatusNoContent, nil)

diff --git a/glusterd2/commands/volumes/volume-option.go b/glusterd2/commands/volumes/volume-option.go
@@ -301,8 +301,6 @@ func volumeOptionsHandler(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	logger.WithField("volume-name", volinfo.Name).Info("volume options changed")
-
 	resp := createVolumeOptionResp(volinfo)
 	restutils.SendHTTPResponse(ctx, w, http.StatusOK, resp)
 }

diff --git a/glusterd2/commands/volumes/volume-start.go b/glusterd2/commands/volumes/volume-start.go
@@ -205,7 +205,6 @@ func volumeStartHandler(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	logger.WithField("volume-name", volinfo.Name).Info("volume started")
 	events.Broadcast(volume.NewEvent(volume.EventVolumeStarted, volinfo))
 
 	resp := createVolumeStartResp(volinfo)

diff --git a/glusterd2/commands/volumes/volume-stop.go b/glusterd2/commands/volumes/volume-stop.go
@@ -191,7 +191,6 @@ func volumeStopHandler(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	logger.WithField("volume-name", volinfo.Name).Info("volume stopped")
 	events.Broadcast(volume.NewEvent(volume.EventVolumeStopped, volinfo))
 
 	resp := createVolumeStopResp(volinfo)

diff --git a/glusterd2/volume/store-utils.go b/glusterd2/volume/store-utils.go
@@ -61,7 +61,6 @@ func GetVolume(name string) (*Volinfo, error) {
 	}
 
 	if resp.Count != 1 {
-		log.WithField("volume", name).Error("volume not found")
 		return nil, gderror.ErrVolNotFound
 	}
 

diff --git a/plugins/device/transaction.go b/plugins/device/transaction.go
@@ -38,7 +38,6 @@ func txnPrepareDevice(c transaction.TxnCtx) error {
 		}
 		return err
 	}
-	c.Logger().WithField("device", device).Info("Device setup successful, setting device status to 'Enabled'")
 
 	availableSize, extentSize, err := lvmutils.GetVgAvailableSize(deviceInfo.VgName())
 	if err != nil {
-Original file line number
+Diff line change
@@ Expand Up @@
     		return
     	}
-    	logger.WithField("volume-name", volinfo.Name).Info("volume deleted")
     	events.Broadcast(volume.NewEvent(volume.EventVolumeDeleted, volinfo))
     	restutils.SendHTTPResponse(ctx, w, http.StatusNoContent, nil)
@@ Expand Down @@