Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website accessibility improvements #352

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

lsfgrd
Copy link

@lsfgrd lsfgrd commented Oct 3, 2021

Related Issue

None

Proposed Changes

  • Remove the outline:none from the plugin button's focused state. It was practically impossible to navigate these buttons with the keyboard without outlines. I also propose adding a condition to only render the "collapsed" state if the user clicks the "+" button instead of having it rendered all the time but not visible. Check the demo bellow;
Screen.Recording.2021-10-03.at.11.05.25.mov
  • Add the aria-label attribute to the "+/x" button to indicate the respective action to screen readers;
  • Add alt text to the logo so screen readers can understand it's a logo;
  • Add the lang property to the html tag to indicate the content's language declaratively.

This is the Lighthouse rating before the changes:
image

After the changes:
image

Here you can see some improvement on SEO and Performance as well.

The Best Practices metric went down due to dev environment not using HTTPs. It should be good live.

@stale
Copy link

stale bot commented Dec 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant