Add charset based variants for trimming, rename from left/right to start/end #696
Conversation
| pub fn trim_start_rtl_test() { | ||
| " עברית " | ||
| |> string.trim_start | ||
| |> should.equal("עברית ") | ||
| } | ||
|
|
||
| pub fn trim_end_rtl_test() { | ||
| " עברית " | ||
| |> string.trim_end | ||
| |> should.equal(" עברית") | ||
| } |
There was a problem hiding this comment.
These tests surprised me, as a native english speaker (I do not speak any RTL languages), but it seems to match Rust's implementation, so I'd be surprised if it was wrong? Happy to be corrected!
There was a problem hiding this comment.
Presumably it's because the RTL text is only in the middle, surrounded by LTR text.
There was a problem hiding this comment.
Ah yeah - I've gone looking and not been able to find an example of a test case that has RTL whitespace I can use to test here. Maybe there is and I'm just not finding it
ollien
force-pushed
the
string-trim-chars
branch
from
45d1a2c
to
2602480
Compare
ollien
force-pushed
the
string-trim-chars
branch
from
2602480
to
db3d5c5
Compare
|
@lpil I can remove the aliases, sure. Though might you consider keeping |
|
Any other changes and additions can be discussed in the issue. There's some unanswered questions there today. |
Fixes #587
The primary intent of this PR is to add
trim_with,trim_start_withandtrim_end_withto thestringmodule, which will trim the specified chars from both ends of a string, the start of a string, or the end of the string, respectively.Given this change from
left/righttostart/end(to be more clear about RTL behavior), I renamed the existingtrim_left/trim_endtotrim_startandtrim_end, and deprecated the old ones. Do let me know if this was an over-reach on my part!The names here are certainly changeable here, I just picked ones that made sense to me :)