Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/plugin interface #219

Open
wants to merge 6 commits into
base: dev-deprecated
Choose a base branch
from

Conversation

bensinober
Copy link

This feature moves sql queries from strings to interface methods so they can be customized per plugin. This way it is easier to separate sql logic from base sql, and write custom plugins.

The main use case is the ability to write a custom plugin that is independent of sql schemas and can be mapped to any existing user database

@Fusion
Copy link
Collaborator

Fusion commented Oct 2, 2021

Thanks! I'm going to review this over the week-end.

@Fusion
Copy link
Collaborator

Fusion commented Oct 2, 2021

@bensinober This may have happened when you created the pull request, due to out of sync branches: your code mostly compiles but chokes on the capabilities sections. You would need to do the same changes with these. For instance, in the FindUser method, there are still direct SQL queries that will fail to compile.

@bensinober
Copy link
Author

Quite so, I failed to keep branch aparts when I tested, so the capabilities query slipped through during rebase. Will fix

@Fusion
Copy link
Collaborator

Fusion commented Oct 22, 2021

Hi @bensinober. While this compiles, I noticed that you changed the FindUser query to not aliasing the user table to u which breaks the queries, since they are built with a criterion of u.xxx

@bensinober
Copy link
Author

You're right of couse. Will revert the removal of table alias

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants