Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix several memory leaks and undefined behaviors #55

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

fix several memory leaks and undefined behaviors #55

wants to merge 3 commits into from

Conversation

hades
Copy link

@hades hades commented Oct 16, 2023 •
edited

Fixes #51, fixes #52

@hades
fix undefined behaviour when devicelist is a malformed XML
16aa6b9 
Calling strncmp with a null pointer is undefined behaviour in the standard
library. Therefore we check first if the type of the node is MXML_ELEMENT and
only then call mxmlGetElement and compare it to the expected node name.
@hades
fix memory leaks in test_storage
0a65815
@hades
fix memory leaks in test_libomemo
d3b0905
@Neustradamus
Copy link
Contributor

@gkdr: Have you seen this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

memory leaks in test_storage memory leaks in test_libomemo
2 participants
@hades @Neustradamus