Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix urls #233

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Fix urls #233

wants to merge 3 commits into from

Conversation

amyschoen
Copy link
Collaborator

Fixing hard-coded URLs in preparation for the OSS release.

Closes #232

@parkerbxyz
Copy link
Contributor

parkerbxyz commented Jul 1, 2020

@amyschoen Thank you so much for doing this! ✨

Everything looks correct, I'd just like to wait until I hear back from @brianamarie regarding the possibility of using a custom domain for this repo before approving the changes: #232 (comment).

@amyschoen
Copy link
Collaborator Author

You're welcome @parkerbxyz, and it makes sense. github.github.io does look a tad odd in the URL.

@amyschoen
Copy link
Collaborator Author

@brianamarie, @parkerbxyz, @BirdyBigBird, I see my WIP PR got approved. Do we have a date for the repo move yet?

@brianamarie
Copy link
Contributor

Hi @amyschoen, thank you for following up.

At this point, we do not have a date planned for moving and renaming the repository. While it's a move we want to make, the urgency is low and the level of impact is unclear, which makes it harder to prioritize. If there are any reasons or upcoming events that we should be considering, please let us know. 😊

In the meantime, thank you for your contributions and for your patience. 🙏

@amyschoen
Copy link
Collaborator Author

There aren't any timelines on my part @brianamarie. I'll keep this as a WIP for now so it doesn't accidentally get merged in.

@amyschoen
Copy link
Collaborator Author

@brianamarie, I've noticed a few approvals lately. Do we have an updated timeline yet for the repo move?

@brianamarie
Copy link
Contributor

Hi @amyschoen! I am not sure where these approvals are coming from... especially seeing that one is now "ghost", which usually means that account is no longer active.

Unfortunately, I am longer able to look after this initiative as actively. @parkerbxyz, is this something you're shepherding, or would like to shepherd, or is this something we'd consider in the backlog until further notice?

@amyschoen
Copy link
Collaborator Author

It's still a draft PR, so no worries about this getting merged in before we're ready. I was just surprised to see a couple approvals recently.

@parkerbxyz
Copy link
Contributor

@parkerbxyz, is this something you're shepherding, or would like to shepherd, or is this something we'd consider in the backlog until further notice?

This is in the backlog, but on my radar. I’m hoping to find time to revisit this soon! 🙂

@herdemu

This comment has been minimized.

Copy link

@herdemu herdemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo

Copy link

@herdemu herdemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo

@djibal

This comment has been minimized.

Copy link

@bee2100cs bee2100cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Copy link

@JhoanAlvear JhoanAlvear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

Copy link

@JhoanAlvear JhoanAlvear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GHGH

Copy link

@donato62 donato62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be pulled

@githubtraining githubtraining locked as spam and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix hard-coded URLs