-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KoLmafia ASH with samples and heuristic #6784
base: main
Are you sure you want to change the base?
Conversation
Typo in visit_url
There's already a PR for this - #5401. Maybe you can contribute to that PR or pull in the changes proposed there, keeping in mind all the comments on that PR. |
Oh wow well done for remembering this. And sorry @midgleyc for missing your work! I think the search I've done, which is just a regex based on the heuristic I wrote, does a better job of reflecting the popularity. I'll update this PR to use Chris's grammar. |
Ok that is done. I note that @midgleyc's PR seems to have run |
This is likely to fail the popularity test again -- I think the number of required repos has only increased since my PR several years ago. A lot of repositories exist only on Sourceforge, and as GitHub doesn't (seem to?) list repos without recent contributions in the search, finding many of the existing scripts is going to be difficult. Even with them, the language likely isn't popular enough. |
The search I have in the description is listing almost 1k files, not sure how to see individual repos but it does seem to be at least a hundred. It would be really great to differentiate these from AGS Scripts! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't accept your samples for a few reasons:
- they're too big; if the diff suppresses them, they're too big for our needs
- they're not covered by an open source license.
All samples must be covered by an open source license and this must be stated in the template and identifiable at the time in the source repo. We will not accept samples without an indication of their license.
We're also going to need the cached license file. This should have been created when you ran script/add-grammar
to add the grammar. Please add that file to the PR. If you can't find it, run this command:
Lines 133 to 134 in 4ac734c
log 'Caching grammar license' | |
bundle exec licensed cache -c vendor/licenses/config.yml |
As with the other PR, popularity still isn't sufficient for inclusion right now.
Description
I am currently missing a grammar - the closest thing that exists is here https://raw.githubusercontent.com/danielyxie/vscode-kolmafia-ash/master/syntaxes/ash.yml. How would you recommend I include that?
Checklist:
#54bd32