Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Null Comments Result #1039

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Handle Null Comments Result #1039

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e39159
Handle null comments result.
devinlyons Feb 6, 2024
9558a6d
Ensure `iterate_pages` never yields null.
devinlyons Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/github_changelog_generator/octo_fetcher.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,13 +434,15 @@ def iterate_pages(client, method, *arguments, parent: nil, **options)
raise(MovedPermanentlyError, response.data[:url]) if response.status == 301
end

yield(last_response.data)
if not last_response.data.nil?
yield(last_response.data)

if parent.nil?
# The snail visits one leaf at a time:
until (next_one = last_response.rels[:next]).nil?
last_response = check_github_response { next_one.get }
yield(last_response.data)
if not last_response.data.nil?
yield(last_response.data)
end
elsif (last = last_response.rels[:last])
# OR we bring out the gatling gun:
Expand All @@ -450,7 +452,8 @@ def iterate_pages(client, method, *arguments, parent: nil, **options)
(2..last_page).each do |page|
parent.async do
data = check_github_response { client.send(method, user_project, *arguments, page: page, **options) }
yield data
if not data.nil?
yield data
end
end
end
Expand Down