Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RevisionDataGridView): Update RowCount while loading #11722

Merged
merged 2 commits into from May 11, 2024

Conversation

mstv
Copy link
Member

@mstv mstv commented May 5, 2024

Proposed changes

  • RevisionDataGridView: (Asynchronously) update RowCount also if DisplayedRowCount returns 0 yet
  • BackgroundUpdater: Always cool down after performing the _operation

Screenshots

Before

revision grid may stay empty until "Loading" is hidden

After

RowCount is updated every 300 milliseconds

Test methodology

  • manual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this May 5, 2024
@mstv mstv marked this pull request as draft May 5, 2024 21:29
@mstv

This comment was marked as outdated.

@mstv mstv marked this pull request as ready for review May 8, 2024 21:52
@mstv
Copy link
Member Author

mstv commented May 8, 2024

Other calls of SetRowCountAndSelectRowsIfReady - at least the one from UpdateGraphAsync - will be removed in a follow-up, or rather the entire function UpdateGraphAsync.

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are understandable, I would have preferred that the extra timer was not needed.

Other calls of SetRowCountAndSelectRowsIfReady - at least the one from UpdateGraphAsync - will be removed in a follow-up, or rather the entire function UpdateGraphAsync.

Can this remove the second timer?

@mstv
Copy link
Member Author

mstv commented May 9, 2024

I would have preferred that the extra timer was not needed.

Other calls of SetRowCountAndSelectRowsIfReady - at least the one from UpdateGraphAsync - will be removed in a follow-up, or rather the entire function UpdateGraphAsync.

Can this remove the second timer?

all done in #11719

@mstv mstv merged commit c037a06 into gitextensions:master May 11, 2024
3 of 4 checks passed
@mstv mstv deleted the fix/graph_loading branch May 11, 2024 21:08
@RussKie RussKie added this to the vNext milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants