Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RevisionDataGridView): Cancel outdated update #11714

Merged
merged 1 commit into from
May 1, 2024

Conversation

mstv
Copy link
Member

@mstv mstv commented Apr 28, 2024

Might fix #11700

Proposed changes

  • RevisionDataGridView.Clear: Cancel outdated update by RevisionDataGridView.UpdateVisibleRowRangeInternalAsync

Screenshots

N/A

Test methodology

  • manual

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@mstv mstv self-assigned this Apr 28, 2024
@pmiossec
Copy link
Member

Might fix #11700

Unfortunately, no...

@mstv
Copy link
Member Author

mstv commented Apr 29, 2024

Might fix #11700

Unfortunately, no...

But my dev branch "fix/graph_redraw" does. Though it suffers from some flicker yet.

This PR is anyway correct and necessary. There is another pending improvement PR waiting for review...

Copy link
Member

@gerhardol gerhardol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The loop in UpdateVisibleRowRangeInternalAsync() is aborted, which seem like the corrct to do.

@mstv mstv merged commit 9d70410 into gitextensions:master May 1, 2024
4 checks passed
@mstv mstv deleted the fix/graph_redraw branch May 1, 2024 15:29
@RussKie RussKie added this to the vNext milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revision graph broken (regression)
4 participants