Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set category to FormClone/FormInit #11403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmitrybozhenok
Copy link
Contributor

Fixes #11312

Proposed changes

Add an option to assign a category on creating or cloning a repository via an editable combobox (disabled by default). I don't think it makes sense from UX point of view to add it also to FormOpen.

Screenshots

Before

image
image

After

image
image
image
image

Test methodology

Manual testing.

Test environment(s)

  • GIT 2.43.0
  • Microsoft Windows NT 10.0.22621.0

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).


✒️ I contribute this code under The Developer Certificate of Origin.

@ghost ghost assigned dmitrybozhenok Nov 27, 2023
Copy link
Member

@pmiossec pmiossec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of duplicated code. Could you create a class that will handle most of the logic?

@ghost ghost added the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Nov 27, 2023
@pmiossec
Copy link
Member

Oh! And you need to run the update-loc.cmd script at the repo root and commit the translation file updated.

@dmitrybozhenok
Copy link
Contributor Author

Thank you for the suggestions, will do!

@ghost ghost removed the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Nov 27, 2023
@vbjay
Copy link
Contributor

vbjay commented Nov 27, 2023

Look at GitHub plugin for another place to add.

@RussKie
Copy link
Member

RussKie commented Nov 28, 2023

The current dialog layout is not great, please move the new control as follows:
image

There's no need for the checkbox - the empty selection implies no category assignment.

Please ensure the tab order of the dialogs remains logical.

@RussKie RussKie added the 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity label Nov 28, 2023
@RussKie
Copy link
Member

RussKie commented Nov 28, 2023

A lot of duplicated code. Could you create a class that will handle most of the logic?

Please create a new user control that encapsulates all the necessary logic.

@ghost ghost added the 💤 status: no recent activity The issue is stale label Dec 12, 2023
@ghost
Copy link

ghost commented Dec 12, 2023

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 14 days. It will be closed if no further activity occurs.

@dmitrybozhenok
Copy link
Contributor Author

dmitrybozhenok commented Dec 12, 2023

Apologies for delay, had other commitments, planning to finish this one soon. Thanks everyone for suggestions, all noted.

@ghost ghost removed 📭 needs: author feedback More info/confirmation awaited from OP; issues typically get closed after 30 days of inactivity 💤 status: no recent activity The issue is stale labels Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add possibility to enter category when repository cloning/creating/opening
5 participants