Serialise scripts

[RussKie]

Proposed changes

• Rename API RepoDistSettings -> DistributedSettings, RepoDistSettingsPage -> DistributedSettingsPage
• Allow to distribute user scripts

Screenshots

Before

After

Test methodology

• TBD

Merge strategy

Don't squash

---

✒️ I contribute this code under The Developer Certificate of Origin.

[RussKie]

Reviving an old changeset. I had a quick test, and it seems to work.
@gerhardol @mstv @pmiossec if you could take it for a spin, it'd be great.

[vbjay]

Recommend guid ids for unique scripts so if same script on multiple layers can get closest to repo setting instead of getting duplicates and instead of using numbers that can colide as different scripts entirely. My 112 global level may be overridden in x repo distributed because number is 112.

If we have a move/copy script around functionality to different layers so a global script has same guid as a distributed in repo then the distributed would win but it would just show 1 script row for the script per level it exists in. Basically overridable scripts.

[mstv]

I guess we need to create unique numbers - at least per category - because all hotkeys have global scope and one cannot know which ids have already been used for repo-specific scripts of another repo.

[vbjay]

Numbers are a BAD idea especially since you have settings levels and across clones of repos. Instead guids should be the new IDs of the scripts. Hotkeys should not be stored across clones. Local and global would make sense. Across repos you will have potential collisions between global and local on different computers.

[mstv]

One needs to select the Scripts settings page once in order to be able to save other settings.
Otherwise:

• Git Extensions 33.33.33
• Build f996428
• Git 2.39.2.windows.1 (recommended: 2.40.0 or later)
• Microsoft Windows NT 10.0.19045.0
• .NET 6.0.15
• DPI 96dpi (no scaling)

System.NullReferenceException: Object reference not set to an instance of an object.
   at GitUI.Script.DistributedScriptsManager.Update(ScriptInfo script) in D:\Build\gitextensions3\GitUI\Script\DistributedScriptsManager.cs:line 177
   at GitUI.CommandsDialogs.SettingsDialog.Pages.ScriptsSettingsPage.PageToSettings() in D:\Build\gitextensions3\GitUI\CommandsDialogs\SettingsDialog\Pages\ScriptsSettingsPage.cs:line 184
   at GitUI.CommandsDialogs.SettingsDialog.SettingsPageBase.SaveSettings() in D:\Build\gitextensions3\GitUI\CommandsDialogs\SettingsDialog\SettingsPageBase.cs:line 99
   at GitUI.CommandsDialogs.FormSettings.Save() in D:\Build\gitextensions3\GitUI\CommandsDialogs\FormSettings.cs:line 236
   at GitUI.CommandsDialogs.FormSettings.Ok_Click(Object sender, EventArgs e) in D:\Build\gitextensions3\GitUI\CommandsDialogs\FormSettings.cs:line 303
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, WM msg, IntPtr wparam, IntPtr lparam)

[mstv]

The icon combobox dropdown should be filled only once, i.e. if empty.

[RussKie]

Thank you. Keep these coming

[mstv]

The sequence of the scripts is not correctly stored or restored.