FileViewer: Don't show too many lines in MessageBox

[bansan85]

Fixes #10709

Proposed changes

• Truncate message to limit the number of lines of string in a MessageBox.

Test environment(s)

• Git Extensions 4.0.2.16100
• Build 25100ec
• Git 2.39.1.windows.1
• Microsoft Windows NT 10.0.22621.0
• .NET 6.0.13
• DPI 96dpi (no scaling)
• Microsoft.WindowsDesktop.App Versions

    Microsoft.WindowsDesktop.App 3.1.26 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 3.1.32 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 6.0.7 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 6.0.10 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 6.0.11 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 6.0.13 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
    Microsoft.WindowsDesktop.App 7.0.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Screenshots

Before

The MessageBox takes the whole height of my screen.

After without "Output truncated" annotation:

After with "Output truncated" annotation:

After with TaskDialog

Indent is lost.

Merge strategy

I agree that the maintainer squash merge this PR (if the commit message is clear).

---

✒️ I contribute this code under The Developer Certificate of Origin.

[RussKie]

Could you please share screenshots before and after?

[mstv]

LGTM, have not run
I think a truncation indicator is not necessary in this case.
As russkie requested, please provide screenshots in all PRs.

[bansan85]

Move screenshot in PR description

[bansan85]

Move more screenshot in PR description

[RussKie]

Thanks for these. Makes ssens. We could additionally use TaskDialog with collapsible middle panel that would contain the diff.

[bansan85]

Use TaskDialog. It's sad that indent is lost. But since I couldn't use a monolith font, indent will always be wrong.

[RussKie]

Could you please share a new screenshot?

[bansan85]

Added in description.

Sorry, I started to update the main description but I forget to click on "Update" button :/

[pmiossec]

@bansan85 I'm not 100% convinced by the design.
Don't you think we could use the Expander feature of the TaskDialog to hide the patch by default and let the user display it if he wants (because most of the times it's useless)?

Like it has been done in #10436...

We could have for the task dialog something like:

• Heading: "Error when applying the patch"
• content: content of output variable
• Expander: content of truncated_diff variable

What do you think?

[bansan85]

Totally agree !! I didn't knew about TaskDialog before yesterday. I will try to improve it.

[RussKie]

Kudos @pmiossec for providing the links. I didn't have those handy.

[RussKie]

@bansan85 a friendly nudge. Is this still something you're working on?

[bansan85]

@RussKie Sorry. I should have kept you in touch.

Not really...

TaskDialog looks cool but after a few hours, I didn't succeed to used it with a good result.

The MessageBox is too width when not expanded.

The MessageBox is too height (didn't found how to insert a scroll) when expanded + it looks that the font can't be customized.

To reproduce it : insert lots of lines with a unicode char and select in the diff window "US-ASCII".

[pmiossec]

The MessageBox is too height (didn't found how to insert a scroll) when expanded + it looks that the font can't be customized.

For me, the idea was to keep the "Output truncated" annotation feature you did when displaying the patch in the task dialog expander. Because, otherwise, you will indeed always have case where the text is too big to be displayed.

For me the content of the patch is not so important. The most important information is that the reset failed. I can't recall one time where I had a look at the patch in this case. So the most important information is the error message you displayed in the main part of the taskdialog 👍

The MessageBox is too width when not expanded.

Strange. Is it due to the content displayed in the expand section?

[RussKie]

I may be able to look into this. Do you have steps to reproduce?

[bansan85]

@RussKie

Thanks if you know how to improve it. The only thing I could do to improve the window is to truncate the number of lines in the expandable part of the form.

To reproduce it : insert lots of lines with a unicode char and select in the diff window "US-ASCII".

Select all lines in diff window, right click and try to revert.