-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Readme #16
Update Readme #16
Conversation
src/GitExtensions.GerritPlugin/GitExtensions.GerritPlugin.csproj.user
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I'd like to have an a better understanding of GitExtensionsReferenceSource
property.
In general, the master branch of any plugin should be build against the latest GE nightly build (i.e. to incorporate API changes that are not yet included in a GE release). Thus, we get the On the other hand, all release branches must (generally) be build against the latest stable GE release, otherwise they might fail in an end users' installation. In this case the More complex scenarios might require to build with an older GE release / CI build. That's when you'll need to change also GitExtensions.GerritPlugin/src/GitExtensions.GerritPlugin/GitExtensions.GerritPlugin.csproj.user Lines 6 to 9 in c25d49c
@thimmy687 : Please base your work on https://github.com/gitextensions/GitExtensions.GerritPlugin/tree/master, not on https://github.com/gitextensions/GitExtensions.GerritPlugin/tree/release/1.0. |
I guess we need first fix this #17, before the build will be able to build. |
68a738d
to
2edb007
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The subject of the PR and the content of the PR do not match...
Please separate and make targeted changes.
Change-Id: I1f01ff4c9752a1b8b9eedd9717787441ed8f2778
Change-Id: Ib1f1332e4009002f21eff718e42203b1a0dbf20c
Change-Id: I1ad18e71d95cc1f1cc9fbea0defbc2b18670bea0
This PR updates the Readme.
The generic template information are removed and the some gerrit plugin information are added