Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme #16

Merged
merged 5 commits into from
Feb 7, 2021
Merged

Update Readme #16

merged 5 commits into from
Feb 7, 2021

Conversation

thimmy687
Copy link
Collaborator

@thimmy687 thimmy687 commented Jan 17, 2021

This PR updates the Readme.
The generic template information are removed and the some gerrit plugin information are added

Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I'd like to have an a better understanding of GitExtensionsReferenceSource property.

@mast-eu
Copy link
Member

mast-eu commented Jan 18, 2021

I'd like to have an a better understanding of GitExtensionsReferenceSource property.

In general, the master branch of any plugin should be build against the latest GE nightly build (i.e. to incorporate API changes that are not yet included in a GE release). Thus, we get the GitExtensionsReferenceSource from the CI (=AppVeyor).

On the other hand, all release branches must (generally) be build against the latest stable GE release, otherwise they might fail in an end users' installation. In this case the GitExtensionsReferenceSource is GitHub, where the released artifacts are stored.

More complex scenarios might require to build with an older GE release / CI build. That's when you'll need to change also GitExtensionsReferenceVersion:

<!-- 'latest' or 'v3.1' (= tag from GitHub releases) or 'v3.1.0.5877' (= build number from AppVeyor)-->
<GitExtensionsReferenceVersion>latest</GitExtensionsReferenceVersion>
<!-- 'GitHub' or 'AppVeyor' -->
<GitExtensionsReferenceSource>AppVeyor</GitExtensionsReferenceSource>

@thimmy687 : Please base your work on https://github.com/gitextensions/GitExtensions.GerritPlugin/tree/master, not on https://github.com/gitextensions/GitExtensions.GerritPlugin/tree/release/1.0.
It's ok if you want to include b692b86 and a6b4645 in your PR. Both commits should, in effect, be on master, too. But for the reason explained above, 6e5c874 should definitely not be on the master branch.

@thimmy687
Copy link
Collaborator Author

I guess we need first fix this #17, before the build will be able to build.

(cherry picked from commit b692b86)
(cherry picked from commit a6b4645)
@thimmy687 thimmy687 force-pushed the master branch 2 times, most recently from 68a738d to 2edb007 Compare January 24, 2021 15:16
@thimmy687 thimmy687 changed the title Update Readme WIP Update Readme Jan 24, 2021
Copy link
Member

@RussKie RussKie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The subject of the PR and the content of the PR do not match...
Please separate and make targeted changes.

src/GitExtensions.GerritPlugin/GerritUICommands.cs Outdated Show resolved Hide resolved
Change-Id: I1f01ff4c9752a1b8b9eedd9717787441ed8f2778
Change-Id: Ib1f1332e4009002f21eff718e42203b1a0dbf20c
Change-Id: I1ad18e71d95cc1f1cc9fbea0defbc2b18670bea0
@thimmy687 thimmy687 changed the title WIP Update Readme Update Readme Feb 6, 2021
@RussKie RussKie merged commit 8040ab0 into gitextensions:master Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants