ci: update FreeBSD image to currently supported 13.2 release

[emaste]

FreeBSD 12.x is now EOL.

[gitgitgadget-git]

Welcome to GitGitGadget

Hi @emaste, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that your Pull Request has a good description, as it will be used as cover letter. You can CC potential reviewers by adding a footer to the PR description with the following syntax:

CC: Revi Ewer <[email protected]>, Ill Takalook <[email protected]>

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

• the lines should not exceed 76 columns,
• the first line should be like a header and typically start with a prefix like "tests:" or "revisions:" to state which subsystem the change is about, and
• the commit messages' body should be describing the "why?" of the change.
• Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

• Search: is:pr is:open "/allow"

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the Libera Chat IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this. Note that any reviewers CC'd via the list in the PR description will not actually be sent emails.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join [email protected], where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Libera Chat. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

[rimrul]

/allow

[gitgitgadget-git]

User emaste is now allowed to use GitGitGadget.

WARNING: emaste has no public email address set on GitHub;
GitGitGadget needs an email address to Cc: you on your contribution, so that you receive any feedback on the Git mailing list. Go to https://github.com/settings/profile to make your preferred email public to let GitGitGadget know which email address to use.

[phil-blain]

Hi @emaste, did you wish to send this to the mailing list ? it would be nice since it would keep the FreeBSD CI builds running correctly :)

[phil-blain]

an identical change has been submitted by @carenas here (thanks!): https://lore.kernel.org/git/[email protected]/

[phil-blain]

Carlos's similar patch is already on master: 81fffb6

[dscho]

$ git range-diff 81fffb66d3f702c269a5aee6e403c3ec62fc0277^! ba3248721914d6918fb75597d415269c714683b7^!

• 1: 81fffb6 ! 1: ba32487 ci: update FreeBSD cirrus job

  @@
    ## Metadata ##
  -Author: Carlo Marcelo Arenas Belón <[email protected]>
  +Author: Ed Maste <[email protected]>
   
    ## Commit message ##
  -    ci: update FreeBSD cirrus job
  +    ci: update FreeBSD image to currently supported 13.2 release
   
  -    FreeBSD 12 is EOL and no longer available, causing errors in this job.
  +    FreeBSD 12.x is now EOL.
   
  -    Upgrade to 13.2, which is the next oldest release with support and that
  -    should keep it for at least another 4 months.
  -
  -    This will be upgraded again once 13.3 is released to avoid further
  -    surprises.
  -
  -    The original report [*] of this problem mentions an error message
  -    "Not enough compute credits to prioritize tasks!".  It seems to be
  -    just a reminder that the credit allocate for the Free Tier by Cirrus
  -    is all used up and which might result in additional delays getting a
  -    result.
  -
  -    [*] https://lore.kernel.org/git/[email protected]/
  -
  -    Signed-off-by: Carlo Marcelo Arenas Belón <[email protected]>
  -    Signed-off-by: Junio C Hamano <[email protected]>
  +    Signed-off-by: Ed Maste <[email protected]>
   
    ## .cirrus.yml ##
   @@
  @@ .cirrus.yml
      CIRRUS_CLONE_DEPTH: 1
    
   -freebsd_12_task:
  -+freebsd_task:
  ++freebsd_13_task:
      env:
        GIT_PROVE_OPTS: "--timer --jobs 10"
        GIT_TEST_OPTS: "--no-chain-lint --no-bin-wrappers"

@emaste Your patch seems to be a bit more specific, whereas @carenas' patch seems a bit more future-proof by avoiding to hard-code the FreeBSD version. Are you good with that?

[carenas]

carenas' patch seems a bit more future-proof by avoiding to hard-code the FreeBSD version.

sadly the image name encodes the version number so the plan was to upgrade the image to 13.3 once that version gets released and which would at least ensure the version used woud have support for a little longer.

@emaste: ammending this PR to do that would be IMHO ideal