Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serbo-Croatian localization #1365

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Conversation

matijakljajic
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 20, 2024

@matijakljajic is attempting to deploy a commit to the giscus Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@laymonage laymonage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hvala!

I'll merge this now, but do you think it's sensible to use the hr language code instead, and have the hbs code as an alias/fall back to the hr translation files? I'm not sure about the political implications, but it seems to be more common to use the name "Croatian" if it exclusively uses the Latin alphabet, and "Serbian" if it uses the Cyrillic alphabet. At least, that's how Google Translate does it.

@laymonage laymonage merged commit 4e10cc3 into giscus:main Apr 21, 2024
0 of 2 checks passed
@matijakljajic
Copy link
Contributor Author

@laymonage

Serbian is practically the only European standard language whose speakers are fully functionally digraphic, using both Cyrillic and Latin alphabets. The Latin alphabet used for Serbian was designed with a one-to-one grapheme-phoneme correlation between the Cyrillic and Latin orthographies, resulting in a parallel system. (Source)

Google Translate may work like that but Serbian has two official scripts, Cyrillic and Latin. (btw Google Translate is not reliable at all for languages not supported by DeepL AFAIK, best to use that for translations)

I've purposely written the localization in a way where it tries to stay neutral regarding the dialect and be inclusive to all variants, at least as much as I could, it's open to updates if not adequate. (every variant uses Latin as an official script)

Croatian and Serbian officially have words which do not appear in both dictionaries even if mutually intelligible, thus it's best to leave the hbs code for this specific localization. (I do not want to anger the politically/nationalistically inclined)

Consequently, if someone wants to add Serbian Cyrillic or Croatian with the use of more localized words they're free to do so with sr and hr codes.

I feel like it's best not to complicate things with sr-latn and sr-cyrl as mentioned here.

@laymonage
Copy link
Member

@matijakljajic That's very helpful, thanks! I'll leave this as-is, then.

@matijakljajic
Copy link
Contributor Author

@laymonage

Type error: Property 'hbs' is missing in type '{ ar: Intl.DateTimeFormat; ca: Intl.DateTimeFormat; da: Intl.DateTimeFormat; de: Intl.DateTimeFormat; en: Intl.DateTimeFormat; eo: Intl.DateTimeFormat; ... 22 more ...; 'zh-TW': Intl.DateTimeFormat; }' but required in type 'Record<"de" | "zh-CN" | "zh-TW" | "ar" | "fa" | "he" | "ca" | "da" | "en" | "eo" | "es" | "fr" | "gr" | "hbs" | "hu" | "id" | "it" | "ja" | "kh" | "ko" | "nl" | "pl" | "pt" | "ro" | "ru" | "th" | "tr" | "vi" | "uk" | "uz", DateTimeFormat>'.

Also I may have accidentally left out this, thus it's failing the build process. Sorry, but please amend or apply a quick-fix.

@laymonage
Copy link
Member

Oops, thanks, fixed in #1367.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants