Add command to propagate annotations #89
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhofer
force-pushed
the
annotation-commands
branch
from
cff4620
to
e6af10d
Compare
dkhofer
force-pushed
the
annotation-commands
branch
from
3669223
to
83aca0b
Compare
Chris7
reviewed
Nov 15, 2024
|
|
||
| let mut path_mappings_by_name = HashMap::new(); | ||
| for (name, target_path) in target_paths_by_name.iter() { | ||
| let source_path = source_paths_by_name.get(name).unwrap(); |
There was a problem hiding this comment.
why do we assume the 2 sample groups need the same paths?
Chris7
reviewed
Nov 15, 2024
| // Replaced (15, 25) with a 2 bp sequence | ||
| // New gene annotation is (5, 15) | ||
| assert_eq!(record.start().get(), 5); | ||
| assert_eq!(record.end().get(), 15); |
There was a problem hiding this comment.
what happens if we throw an insert into a gene? wondering if we split it up or just extend it.
Chris7
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.