Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning cleanup, fix or ignore failing tests #51

Merged
merged 3 commits into from
Sep 23, 2024
Merged

Conversation

dkhofer
Copy link
Collaborator

@dkhofer dkhofer commented Sep 20, 2024

No description provided.

Copy link
Collaborator

@Chris7 Chris7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll try to fix these before final merges in the future. I don't like being blocked on warnings for dev but should clean it up before the final merge.

@dkhofer dkhofer merged commit 8002f92 into main Sep 23, 2024
1 check passed
@Chris7 Chris7 deleted the september-2024-cleanup branch September 24, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants