Readme with David's comments addressed #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhofer
reviewed
Sep 19, 2024
| 2. Compile the gen package and its dependencies: | ||
|
|
||
| ``` | ||
| cargo build |
There was a problem hiding this comment.
Might need one more sentence here explaining that the gen executable is in a directory under target/ that gets created after running cargo build
There was a problem hiding this comment.
Will keep that in mind for the next revision. I was wondering if cargo --run -- [gen arguments] is preferable to ./target/debug/gen
|
One nonblocking comment, LGTM! |
dkhofer
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit log is a mess (sorry), but this one should merge and address your comments.