Operation branch support #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhofer
reviewed
Sep 18, 2024
| id INTEGER PRIMARY KEY NOT NULL, | ||
| db_uuid TEXT NOT NULL, | ||
| name TEXT NOT NULL, | ||
| start_operation_id INTEGER, |
There was a problem hiding this comment.
These are foreign keys on operation.id, right? If so please add constraints
dkhofer
reviewed
Sep 18, 2024
| UPDATE SET branch_id=excluded.branch_id;", | ||
| ) | ||
| .unwrap(); | ||
| println!("setting branc to {branch_name}"); |
|
LGTM, comments are non-blocking |
dkhofer
approved these changes
Sep 18, 2024
|
Thanks, ill resolve comments in the apply branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds in support for branches and moving between branches. Not in yet is applying changes between branches.