GFA export #42
GFA export #42
Conversation
dkhofer
force-pushed
the
gfa-export
branch
2 times, most recently
from
dc47915
to
26a3c33
Compare
| } | ||
| } | ||
|
|
||
| (graph, edges_by_node_pair) |
There was a problem hiding this comment.
I don't love having to return edges_by_node_pair here, but I couldn't think of a more elegant way to get a mapping from one representation of edge (pair of black IDs) to the regular edge object
There was a problem hiding this comment.
I think we can assign more information to edges than we have been, but we can do that later. the () part of the DiGraphMap is edge storage iirc. So we could put some custom structure there.
There was a problem hiding this comment.
Oh, good to know. I'll keep that in mind
| @@ -255,218 +239,11 @@ impl BlockGroup { | |||
| } | |||
| } | |||
|
|
|||
| pub fn get_block_boundaries( | |||
There was a problem hiding this comment.
Most of this is just refactoring, moving it into the Edge model, which I think is a better place for it.
| @@ -0,0 +1,70 @@ | |||
| use rusqlite::types::Value; | |||
There was a problem hiding this comment.
Felt like putting Collection into its own file while I was at it
| .into_string() | ||
| .unwrap(); | ||
|
|
||
| export_gfa(&conn, collection_name, &gfa_path); |
There was a problem hiding this comment.
just a fyi, you can use pathbuf and avoid the string conversions
There was a problem hiding this comment.
Oh yeah, that does simplify things a bit, done here and with gfa imports
| } | ||
| } | ||
|
|
||
| (graph, edges_by_node_pair) |
There was a problem hiding this comment.
I think we can assign more information to edges than we have been, but we can do that later. the () part of the DiGraphMap is edge storage iirc. So we could put some custom structure there.
No description provided.