Sequence from disk #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris7
force-pushed
the
sequence-default
branch
from
c469836
to
5b228a0
Compare
dkhofer
reviewed
Aug 26, 2024
| println!( | ||
| "{path_start} {path_end} {start} {end} {contains_start} {contains_end} {overlap}" | ||
| ); | ||
| // println!( |
There was a problem hiding this comment.
What's the reason for commenting this out?
dkhofer
reviewed
Aug 26, 2024
| let mut rows = stmt | ||
| .query_map((block_id,), |row| Ok((row.get(0)?, row.get(1)?))) | ||
| .query_map((block_id,), |row| { |
There was a problem hiding this comment.
This is all going to have to go somewhere else to work with the new edges
There was a problem hiding this comment.
Maybe edge_pairs_to_block: https://github.com/ginkgobioworks/gen/blob/main/src/models/path.rs#L178C12-L178C31
dkhofer
reviewed
Aug 26, 2024
| @@ -2,19 +2,35 @@ use rusqlite::types::Value; | |||
| use rusqlite::{params_from_iter, Connection}; | |||
| use sha2::{Digest, Sha256}; | |||
|
|
|||
| #[derive(Debug)] | |||
| #[derive(Debug, Default)] | |||
There was a problem hiding this comment.
Not bad, I'd say the default params works fairly reasonably
|
Overall looks good, but I'd like to take another look once it's been rebased and updated |
|
implemented via #24 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support storing sequences on disk instead of in db.
I removed the bio crate in favor of noodles as we are extensively using that elsewhere. I tried a new pattern for making it simpler to expand the Sequence model in the future. I know we discussed the builder/default pattern, and one thing I think may point to the builder being better is it will have fewer copies and less use of to_string.