Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Debian 12 and Ubuntu 24.04 #428

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

flichtenheld
Copy link
Contributor

Simple copy of Debian 11 and Ubuntu 22.04 config. Saw no reason to change any of the defaults. Definitely better than the global defaults...

Fixes: #427

@baurmatt
Copy link
Contributor

Can confirm that this is required and works as expected. Otherwise the global default lead to this error:

Error: Systemd start for sshd failed!
journalctl log for sshd:
-- No entries --

Error: /Stage[main]/Ssh::Server/Service[sshd_service]/ensure: change from 'stopped' to 'running' failed: Systemd start for sshd failed!
journalctl log for sshd:
-- No entries --

@ghoneycutt Can we please get this merged and released? :)

@ghoneycutt
Copy link
Owner

This data is valid, so people can copy it and use it today before it is merged as this module is forward compatible in that way.

@ghoneycutt
Copy link
Owner

@flichtenheld could you please add the acceptance testing to support this?

@flichtenheld
Copy link
Contributor Author

Will do

@flichtenheld
Copy link
Contributor Author

@flichtenheld could you please add the acceptance testing to support this?

@ghoneycutt Added enough to make pdk test unit pass. Let me know if there is anything else I should run.

@flichtenheld flichtenheld force-pushed the u24 branch 2 times, most recently from 7d9b90c to 3b3bdd8 Compare December 3, 2024 13:47
Simple copy of Debian 11 and Ubuntu 22.04 config. Saw
no reason to change any of the defaults. Definitely better
than the global defaults...

Fixes: ghoneycutt#427

Signed-off-by: Frank Lichtenheld <[email protected]>
@flichtenheld
Copy link
Contributor Author

Now also enabled GHA tests and rebased on newest main.

@ghoneycutt
Copy link
Owner

Approved the tests and they are coming up with errors.

@ghoneycutt ghoneycutt merged commit b698c03 into ghoneycutt:main Dec 10, 2024
18 checks passed
@ghoneycutt
Copy link
Owner

Thanks @baurmatt and @flichtenheld !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sshd Ubuntu 24.04
3 participants