Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for decoding using FFmpeg in the main example #2432

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

shih-liang
Copy link

No description provided.

@easyfab
Copy link

easyfab commented Sep 26, 2024

Could be interesting to have this in main for those you don't want to install ffmpeg.
But you can also simply use directlty ffmpeg to pipe into main.
e.g. : ffmpeg -i file -ar 16000 -ac 2 -c:a pcm_s16le -f wav - | main -m model.bin -f -

@imaami
Copy link

imaami commented Dec 13, 2024

The main commit is absolutely flooded with unnecessary and invasive whitespace and brace style changes. Even if such changes were called for, they would belong in a separate commit instead of mixed in with functional changes.

To clarify: the problem in this PR isn't just whitespace fixes polluting a functional commit. These aren't whitespace fixes, they're just changes. For example, one function which was originally indented with four spaces is changed to tab indentation, and above it a tab-indented function is changed to four-space indentation...

The upstream code does suffer from a bad case of mixed indentation, but any fixes need to be in separate PRs or at least in separate commits. And of course they need to actually be consistent to be fixes at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants