log: refine log function for Android #2071
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imaami
reviewed
Dec 13, 2024
| WHISPER_ATTRIBUTE_FORMAT(2, 3) | ||
| static void whisper_log_internal (ggml_log_level level, const char * format, ...); | ||
| WHISPER_ATTRIBUTE_FORMAT(5, 6) | ||
| static void whisper_log_internal (ggml_log_level level, const char * file, const char * func, int line, const char * format, ...); |
There was a problem hiding this comment.
Why add these three parameters at such a low level?
imaami
reviewed
Dec 13, 2024
| int len = vsnprintf(buffer, 1024, format, args); | ||
| if (len < 1024) { | ||
| int len_prefix = snprintf(buffer, 1024, "[%s, %d]: ", func, line); // param file not used in this file | ||
| int len = vsnprintf(buffer + len_prefix, 1024 - len_prefix, format, args); |
There was a problem hiding this comment.
if snprintf fails due to an output error then this will write to an address before the buffer's start.
|
The macros |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
are defined by Android NDK, not self-defined macro. so it will not bring side-effect to existing codes.
this PR is prepare for submit Qualcomm's QNN backend to upstream whisper.cpp from "PoC: Add Qualcomm mobile SoC native backend for GGML,zhouwg/kantv#121 ".
the first step is for whisper.cpp, then llama.cpp, because llama.cpp is much more complicated then whisper.cpp