Fix floating point error with ndot progress printing in Perplexity and show stats with < 100 tasks #7348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix floating point error with ndot printing, allow end stats on lower task numbers if multiple-choice tasks.
mofosyne
added
bugfix
ggerganov
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple 2 line PR is to allow --multiple-choice with a --binary-file that has less than 100 tasks.
I've made a JSON->bin encoder, but as I discovered here when testing the encoder, with fewer than 100 tasks you get a floating point error on a simple function that just prints progress dots.
I've also changed a line to allow printing the stats at the end (score % vs guess %) if you're using all multiple choice tasks (of any number), rather than just >= 100.