Add support for pipeline-overridable constants in web backend #5688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wumpf
requested changes
May 12, 2024
cwfitzgerald
previously requested changes
May 14, 2024
|
(Reminder: please re-request a review from me once the changes are addressed to make sure I see it!) |
Wumpf
approved these changes
May 14, 2024
There was a problem hiding this comment.
Thanks for the neatly documented util, much nicer :)
🟢 from my side, but let's hear out @cwfitzgerald now that he's in on the fun :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#5500 - Pipeline-overridable constants
Description
I was excited to try out the new pipeline-overridable constants that were added in version 0.20, but unfortunately, I discovered that they didn't work on the web! This change copies the
constantsdictionary into the Javascript-side pipeline descriptors so that pipeline-overridable constants work with WebGPU.Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.