Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to create and verify base url permutations. #2484

Draft
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

jamwil
Copy link

@jamwil jamwil commented Apr 26, 2024

Unit tests to verify that a site::Site is successfully built and contains valid permalinks using the new base url logic in src/cmd/serve.rs introduced in #2311.

Closes #2448.

I am marking this as a draft for now. This tests the create_new_site function and verifies the urls and paths, but I'd like to add further tests of the actual live hyper endpoint.

Note that the tests will fail until this rebased on #2482 as that PR makes the trailing slash behaviour consistent with prior before we added the construct_base_url function.

Sanity check:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

Code changes

(Delete or ignore this section for documentation changes)

  • Are you doing the PR on the next branch?

If the change is a new feature or adding to/changing an existing one:

  • Have you created/updated the relevant documentation page(s)?

@jamwil jamwil force-pushed the test-serve branch 2 times, most recently from 19dc8a1 to 551c2f9 Compare April 26, 2024 22:23
@jamwil jamwil changed the title Add unit tests to create a verify base url permutations. Add unit tests to create and verify base url permutations. Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant