Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add just download #1060

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Conversation

highghlow
Copy link
Contributor

@highghlow highghlow commented Apr 19, 2024

This time it's my own app!

App Submission

App name

Just. Download.
or
Just Download

256x256 SVG icon

(Submit an icon with no rounded corners as it will be dynamically rounded with CSS. GitHub doesn't allow uploading SVGs directly, so please upload your icon to an alternate service, like https://svgur.com, and paste the link below.)
We will help finalize this icon before the app goes live in the Umbrel App Store.

If I manually insert the icon into Umbrel's homepage, it is just a little bit too bit

https://raw.githubusercontent.com/highghlow/just-download/main/public/icon.svg

Gallery images

(Upload 3 to 5 high-quality gallery images (1440x900px) of your app in PNG format, or just upload 3 to 5 screenshots of your app and we'll help you design the gallery images.)
We will help finalize these images before the app goes live in the Umbrel App Store.

1713553024158

image

Yes, the search results are in Russian because I'm using rutracker.org as my indexer. The actual app is in english.

UPDATE: After I updated to Umbrel v1 I cannot use this app. The indexer I use requires a proxy. I used tor as a proxy, but now I cannot customize it's torrc and add bridges.

Please make it look cool!

I have tested my app on:

  • umbrelOS on a Raspberry Pi
  • umbrelOS on an Umbrel Home
  • umbrelOS on Linux VM

@highghlow
Copy link
Contributor Author

The app still requires a better configuration screen, but other than that, it's functional

@nmfretz
Copy link
Contributor

nmfretz commented May 30, 2024

Thanks for making your own app and submitting to the official app store @highghlow! I've just played around with it.

The app still requires a better configuration screen, but other than that, it's functional

With the current app requiring users to have knowledge of the precise format to use when adding an indexer to the configuration array, do you want to launch this app as part of your own Community App Store until you've built out the UI further? Right now I could see the following flow being too difficult for the average user to figure out if they were to install Just. Download.

Kapture.2024-05-30.at.13.52.05.mp4

@highghlow
Copy link
Contributor Author

do you want to launch this app as part of your own Community App Store until you've built out the UI further?

Okay, I'll stop procrastinating and add a proper config screen now

@highghlow
Copy link
Contributor Author

Just as I said that my archlinux system died and docker imposed sanctions on my country. It took a little bit longer than I expected, but there is now a proper config menu, @nmfretz . I can't test it on my umbrel now, but I will in a few hours

Copy link
Contributor

@nmfretz nmfretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a config screen to the UI @highghlow.

I can't test it on my umbrel now, but I will in a few hours

No worries, I just tested and left a review with a few suggestions to finalize things.

Also, one other in-app fix you may want to consider is that the description field in the results page is always blank so you can't actually tell what to download:

image

You can also see this in my screen recording here: #1060 (comment)

It's happening because the search results are usually returning null for results[index].description. Was this supposed to render the data from results[index].title instead?

just-download/docker-compose.yml Outdated Show resolved Hide resolved
just-download/docker-compose.yml Outdated Show resolved Hide resolved
just-download/umbrel-app.yml Show resolved Hide resolved
@highghlow
Copy link
Contributor Author

It's happening because the search results are usually returning null for results[index].description. Was this supposed to render the data from results[index].title instead?

If think I did this because jackett-rutracker returns a cut-down version of the title in title. I'll add a config option for this

@highghlow
Copy link
Contributor Author

Alright, @nmfretz . Everything is now fixed

@highghlow
Copy link
Contributor Author

The new "Use title as description" option is set to false on previously added indexers, but defaults to true on new ones

@nmfretz
Copy link
Contributor

nmfretz commented Jun 5, 2024

Thanks @highghlow! Okay, we shall get some gallery images made up.

@highghlow
Copy link
Contributor Author

Yay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants