Save task before closing editor #1175
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes getting-things-gnome#1138 When the task editor gets closed, it first calls `self.textview.process()` which, after processing, calls `self.save_cb()`, which is set to `TaskEditor.light_save()`. This only calls `TaskEditor.save()` at most every 7 seconds. So if you crete a new task and close its editor within 7 seconds, the task doesn't get saved. This commit makes `TaskEditor.desctruction()` call `TaskEditor.save()`, to make sure the task is saved properly before closing the task popup.
SqAtx
commented
Jan 20, 2025
| # self.pengine.onTaskClose(self.plugin_api) | ||
| # self.pengine.remove_api(self.plugin_api) | ||
|
|
||
| tid = self.task.id | ||
|
|
||
| if self.is_new(): | ||
| if self.task.is_new(): |
There was a problem hiding this comment.
def is_new(self) -> bool:
return self.task.is_new()
I wouldn't mind getting rid of that method eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1138
When the task editor gets closed, it first calls
self.textview.process()which, after processing, callsself.save_cb(), which is set toTaskEditor.light_save(). This only callsTaskEditor.save()at most every 7 seconds. So if you crete a new task and close its editor within 7 seconds, the task doesn't get saved.This commit makes
TaskEditor.desctruction()callTaskEditor.save(), to make sure the task is saved properly before closing the task popup.