add specific status code for sops errors #1245
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaedwen <[email protected]>
sops.go
Outdated
| } | ||
|
|
||
| // MacMismatch occurs when the computed MAC does not match the expected ones | ||
| const MacMismatch = sopsError("MAC mismatch") | ||
| var MacMismatch = &SopsError{10, "MAC mismatch"} |
There was a problem hiding this comment.
Please note that there is already another exit code defined in cmd/sops/codes/codes.go. Please use the constants from there.
sops.go
Outdated
|
|
||
| // MetadataNotFound occurs when the input file is malformed and doesn't have sops metadata in it | ||
| const MetadataNotFound = sopsError("sops metadata not found") | ||
| var MetadataNotFound = &SopsError{11, "sops metadata not found"} |
There was a problem hiding this comment.
There is no code yet for that, a new constant should be added to cmd/sops/codes/codes.go and used here.
This appears to be a 7 year old, unmaintained, unused, artifact from around the time things were still written in Python. As observed earlier in getsops#1234. As this now actively triggers a security warning due to an outdated dependency, remove it. Signed-off-by: Hidde Beydals <[email protected]>
By addressing the bug in the introduced logic around the `GOOGLE_CREDENTIALS` environment variable. The variable is now only taken into account when set, and actually containing a value. Signed-off-by: Hidde Beydals <[email protected]>
Most of the rewritten key sources introduced `WithError` calls, which does not appear to go well with the UX of the CLI. This reverts it to be the semi equal to current `master`. During the diff, I noticed the current age implementation in master does make use of `WithError`. Which makes me wonder if errors are not returned twice at present in the CLI. Signed-off-by: Hidde Beydals <[email protected]>
This commit renames the Go module from `go.mozilla.org/sops/v3` to `github.com/getsops/sops/v3` without a major version bump, to align with new stewardship. For more information around this change, refer to getsops#1246. For a one-liner to change the `go.mod` and any import paths in your Go project making use of this module, run: ``` find /path/to/repo -type f \( -name "*.go" -o -name "go.mod" \) -exec sed -i 's|go.mozilla.org/sops/v3|github.com/getsops/sops/v3|g' {} \; find /path/to/repo -type f \( -name "*.go" -o -name "go.mod" \) -exec sed -i '' 's|go.mozilla.org/sops/v3|github.com/getsops/sops/v3|g' {} \; ``` Signed-off-by: Hidde Beydals <[email protected]>
This was historically used to generate https://go.mozilla.org/sops/, which is not under our control. Signed-off-by: Hidde Beydals <[email protected]>
- github.com/aws/aws-sdk-go-v2 to v1.20.1 - github.com/aws/aws-sdk-go-v2/config to v1.18.33 - github.com/aws/aws-sdk-go-v2/credentials to v1.13.32 - github.com/aws/aws-sdk-go-v2/feature/s3/manager to v1.11.77 - github.com/aws/aws-sdk-go-v2/service/kms to v1.24.2 - github.com/aws/aws-sdk-go-v2/service/s3 to v1.38.2 - github.com/aws/aws-sdk-go-v2/service/sts to v1.21.2 Signed-off-by: Hidde Beydals <[email protected]>
While also updating the deprecated API module to `cloud.google.com/go/kms/apiv1/kmspb`. Signed-off-by: Hidde Beydals <[email protected]>
- github.com/Azure/azure-sdk-for-go/sdk/azcore to v1.7.0 - github.com/Azure/azure-sdk-for-go/sdk/security/keyvault/azkeys to v1.0.0 This includes dealing with some breaking changes, which should be the last ones for the foreseeable future as they tagged it as the first MAJOR. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
This adds the base for releasing using GoReleaser going forward in a backwards compatible manner, which means: - Publishing of artifacts in the same formats as previous releases - Publishing of RPM and deb artifacts in the same formats as previous releases (although the metadata may need a bit of tweaking) In addition, it includes: - SBOM inclusion per binary artifact It still needs work around: - Artifact signing - SLSA compliance - Docker images - GitHub release - Changelog generation - GitHub Action workflow Signed-off-by: Hidde Beydals <[email protected]>
GoReleaser requires specifically crafted Dockerfiles as the build context is dynamically constructed. For more information, refer to https://goreleaser.com/errors/docker-build/#do and other documentation around Docker image templates and manifests. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
This appears to be the best option at present to e.g. celebrate new contributors while also allowing things to be grouped by pull request label. For more information, see xrefs in patch. Signed-off-by: Hidde Beydals <[email protected]>
This still needs further configuration of at least the `.header` field. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Plus a tiny nit to not have to pass `--yes` to Cosign everywhere, and enabling of size reporting. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
These are no longer required, as they are now handled by GoReleaser or no longer under our control (`make_download_page.sh`). Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Which in turn solves the generation of the checksum file. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Looking more at this, it would actually be great if we would detect multi-line errors from GnuPG in `Import()`, `Decrypt()` and `Encrypt()` so that we can slightly improve the formatting of the errors with a newline seperator before the `gpg: ...\ngpg: ...` output. As this would likely increase readability. Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
- github.com/Azure/azure-sdk-for-go/sdk/azidentity to v1.4.0 - github.com/ProtonMail/go-crypto to v0.0.0-20230923063757-afb1ddc0824c - github.com/google/go-cmp to v0.6.0 - golang.org/x/net to v0.17.0 - google.golang.org/api to v0.146.0 - google.golang.org/genproto/googleapis/rpc to v0.0.0-20231009173412-8bfb1ae86b6c - google.golang.org/grpc to v1.58.3 Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Signed-off-by: Benjamin Ludewig <[email protected]>
Signed-off-by: Benjamin Ludewig <[email protected]>
Signed-off-by: Hidde Beydals <[email protected]>
Bumps the go group with 6 updates: | Package | From | To | | --- | --- | --- | | [cloud.google.com/go/kms](https://github.com/googleapis/google-cloud-go) | `1.15.2` | `1.15.3` | | [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) | `1.21.1` | `1.21.2` | | [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.18.44` | `1.18.45` | | [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2) | `1.11.89` | `1.11.90` | | [github.com/aws/aws-sdk-go-v2/service/kms](https://github.com/aws/aws-sdk-go-v2) | `1.24.6` | `1.24.7` | | [google.golang.org/api](https://github.com/googleapis/google-api-go-client) | `0.146.0` | `0.147.0` | Updates `cloud.google.com/go/kms` from 1.15.2 to 1.15.3 - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md) - [Commits](googleapis/google-cloud-go@kms/v1.15.2...kms/v1.15.3) Updates `github.com/aws/aws-sdk-go-v2` from 1.21.1 to 1.21.2 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@v1.21.1...v1.21.2) Updates `github.com/aws/aws-sdk-go-v2/config` from 1.18.44 to 1.18.45 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@config/v1.18.44...config/v1.18.45) Updates `github.com/aws/aws-sdk-go-v2/feature/s3/manager` from 1.11.89 to 1.11.90 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@feature/s3/manager/v1.11.89...feature/s3/manager/v1.11.90) Updates `github.com/aws/aws-sdk-go-v2/service/kms` from 1.24.6 to 1.24.7 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/fsx/v1.24.6...service/fsx/v1.24.7) Updates `google.golang.org/api` from 0.146.0 to 0.147.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.146.0...v0.147.0) --- updated-dependencies: - dependency-name: cloud.google.com/go/kms dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/feature/s3/manager dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/service/kms dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go ... Signed-off-by: dependabot[bot] <[email protected]>
Due to the AWS SDK addressing a bug, which causes it to be more strict when loading a configured profile. Signed-off-by: Hidde Beydals <[email protected]>
Bumps the go group with 3 updates: [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2), [google.golang.org/api](https://github.com/googleapis/google-api-go-client) and [google.golang.org/grpc](https://github.com/grpc/grpc-go). Updates `github.com/aws/aws-sdk-go-v2/config` from 1.18.45 to 1.19.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/v1.19.0/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@config/v1.18.45...v1.19.0) Updates `google.golang.org/api` from 0.147.0 to 0.148.0 - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.147.0...v0.148.0) Updates `google.golang.org/grpc` from 1.58.3 to 1.59.0 - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.58.3...v1.59.0) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: google.golang.org/api dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the go group with 1 update: [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2). - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@feature/s3/manager/v1.11.90...feature/s3/manager/v1.11.91) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/feature/s3/manager dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.24+incompatible to 24.0.7+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.24...v24.0.7) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the go group with 3 updates: [cloud.google.com/go/kms](https://github.com/googleapis/google-cloud-go), [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) and [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2). Updates `cloud.google.com/go/kms` from 1.15.3 to 1.15.4 - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md) - [Commits](googleapis/google-cloud-go@kms/v1.15.3...kms/v1.15.4) Updates `github.com/aws/aws-sdk-go-v2/config` from 1.19.0 to 1.19.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/v1.19.1/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@v1.19.0...v1.19.1) Updates `github.com/aws/aws-sdk-go-v2/feature/s3/manager` from 1.11.91 to 1.11.92 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@feature/s3/manager/v1.11.91...feature/s3/manager/v1.11.92) --- updated-dependencies: - dependency-name: cloud.google.com/go/kms dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/feature/s3/manager dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Bastien Wermeille <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Bumps the go group with 7 updates: | Package | From | To | | --- | --- | --- | | [cloud.google.com/go/kms](https://github.com/googleapis/google-cloud-go) | `1.15.4` | `1.15.5` | | [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) | `1.33.0` | `1.34.1` | | [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) | `1.21.2` | `1.22.1` | | [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.19.1` | `1.22.0` | | [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2) | `1.11.92` | `1.13.1` | | [github.com/aws/aws-sdk-go-v2/service/kms](https://github.com/aws/aws-sdk-go-v2) | `1.24.7` | `1.26.0` | | [github.com/fatih/color](https://github.com/fatih/color) | `1.15.0` | `1.16.0` | Updates `cloud.google.com/go/kms` from 1.15.4 to 1.15.5 - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md) - [Commits](googleapis/google-cloud-go@kms/v1.15.4...kms/v1.15.5) Updates `cloud.google.com/go/storage` from 1.33.0 to 1.34.1 - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md) - [Commits](googleapis/google-cloud-go@pubsub/v1.33.0...spanner/v1.34.1) Updates `github.com/aws/aws-sdk-go-v2` from 1.21.2 to 1.22.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@v1.21.2...v1.22.1) Updates `github.com/aws/aws-sdk-go-v2/config` from 1.19.1 to 1.22.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@v1.19.1...v1.22.0) Updates `github.com/aws/aws-sdk-go-v2/feature/s3/manager` from 1.11.92 to 1.13.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/config/v1.13.1/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@feature/s3/manager/v1.11.92...config/v1.13.1) Updates `github.com/aws/aws-sdk-go-v2/service/kms` from 1.24.7 to 1.26.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/s3/v1.26.0/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@service/fsx/v1.24.7...service/s3/v1.26.0) Updates `github.com/fatih/color` from 1.15.0 to 1.16.0 - [Release notes](https://github.com/fatih/color/releases) - [Commits](fatih/color@v1.15.0...v1.16.0) --- updated-dependencies: - dependency-name: cloud.google.com/go/kms dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go - dependency-name: cloud.google.com/go/storage dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/feature/s3/manager dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/service/kms dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/fatih/color dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Mitar <[email protected]>
Bumps the ci group with 1 update: [sigstore/cosign-installer](https://github.com/sigstore/cosign-installer). - [Release notes](https://github.com/sigstore/cosign-installer/releases) - [Commits](sigstore/cosign-installer@11086d2...1fc5bd3) --- updated-dependencies: - dependency-name: sigstore/cosign-installer dependency-type: direct:production update-type: version-update:semver-minor dependency-group: ci ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps the go group with 7 updates: | Package | From | To | | --- | --- | --- | | [cloud.google.com/go/storage](https://github.com/googleapis/google-cloud-go) | `1.34.1` | `1.35.1` | | [github.com/Azure/azure-sdk-for-go/sdk/azcore](https://github.com/Azure/azure-sdk-for-go) | `1.8.0` | `1.9.0` | | [github.com/aws/aws-sdk-go-v2](https://github.com/aws/aws-sdk-go-v2) | `1.22.1` | `1.22.2` | | [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) | `1.22.0` | `1.23.0` | | [github.com/aws/aws-sdk-go-v2/feature/s3/manager](https://github.com/aws/aws-sdk-go-v2) | `1.13.1` | `1.13.5` | | [github.com/aws/aws-sdk-go-v2/service/kms](https://github.com/aws/aws-sdk-go-v2) | `1.26.0` | `1.26.1` | | [golang.org/x/net](https://github.com/golang/net) | `0.17.0` | `0.18.0` | Updates `cloud.google.com/go/storage` from 1.34.1 to 1.35.1 - [Release notes](https://github.com/googleapis/google-cloud-go/releases) - [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md) - [Commits](googleapis/google-cloud-go@spanner/v1.34.1...storage/v1.35.1) Updates `github.com/Azure/azure-sdk-for-go/sdk/azcore` from 1.8.0 to 1.9.0 - [Release notes](https://github.com/Azure/azure-sdk-for-go/releases) - [Changelog](https://github.com/Azure/azure-sdk-for-go/blob/main/documentation/release.md) - [Commits](Azure/azure-sdk-for-go@sdk/azcore/v1.8.0...sdk/azcore/v1.9.0) Updates `github.com/aws/aws-sdk-go-v2` from 1.22.1 to 1.22.2 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@v1.22.1...v1.22.2) Updates `github.com/aws/aws-sdk-go-v2/config` from 1.22.0 to 1.23.0 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@v1.22.0...config/v1.23.0) Updates `github.com/aws/aws-sdk-go-v2/feature/s3/manager` from 1.13.1 to 1.13.5 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/service/mq/v1.13.5/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@config/v1.13.1...service/mq/v1.13.5) Updates `github.com/aws/aws-sdk-go-v2/service/kms` from 1.26.0 to 1.26.1 - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@service/s3/v1.26.0...service/s3/v1.26.1) Updates `golang.org/x/net` from 0.17.0 to 0.18.0 - [Commits](golang/net@v0.17.0...v0.18.0) --- updated-dependencies: - dependency-name: cloud.google.com/go/storage dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/Azure/azure-sdk-for-go/sdk/azcore dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/feature/s3/manager dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go - dependency-name: github.com/aws/aws-sdk-go-v2/service/kms dependency-type: direct:production update-type: version-update:semver-patch dependency-group: go - dependency-name: golang.org/x/net dependency-type: direct:production update-type: version-update:semver-minor dependency-group: go ... Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Felix Fontein <[email protected]>
Signed-off-by: kaedwen <[email protected]>
|
The commit history looks pretty bad, can you please try to rebase with the current |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to introduce explicit handling of sops errors to find out what did go wrong. This is a simple change without and we can know what went wrong during the run.