Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spans): Configure and ingest new microsecond precision fields #5931

Merged
merged 11 commits into from
May 21, 2024
Merged

feat(spans): Configure and ingest new microsecond precision fields #5931

merged 11 commits into from
May 21, 2024

Conversation

phacops
Copy link
Contributor

@phacops phacops commented May 16, 2024

Click the merge button by accident and it merged into my branch adding the migration.

#5925

@phacops phacops requested review from a team as code owners May 16, 2024 20:05
@codecov Codecov
Copy link

codecov bot commented May 16, 2024 •
edited

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 412 tests with 1 failed, 410 passed and 1 skipped.

View the full list of failed tests
Test Description Failure message 
Testsuite:
pytest

Test name:
tests.test_spans_api.TestSpansApi::test_count_for_project

Envs:
- default
 
No failure message available

Base automatically changed from pierre/spans-add-microseconds-precision-timestamps to master May 16, 2024 20:24
@phacops phacops force-pushed the pierre/spans-add-microseconds-precision-timestamps-configuration-2 branch from cf6dcbd to 9ef9be3 Compare May 17, 2024 12:12
@getsentry getsentry deleted a comment from github-actions bot May 17, 2024
gggritso
gggritso approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_precise is funny since the other fields have specific precision suffixes like _ms, but that's barely a nit

@phacops phacops merged commit 96f265b into master May 21, 2024
30 checks passed
@phacops phacops deleted the pierre/spans-add-microseconds-precision-timestamps-configuration-2 branch May 21, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gggritso gggritso gggritso approved these changes

@Swatinem Swatinem Awaiting requested review from Swatinem

@enochtangg enochtangg Awaiting requested review from enochtangg

@loewenheim loewenheim Awaiting requested review from loewenheim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@phacops @Swatinem @gggritso @loewenheim @enochtangg