Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): Add screenshots in feedback item #66530

Merged
merged 4 commits into from
Mar 7, 2024

Conversation

c298lee
Copy link
Member

@c298lee c298lee commented Mar 7, 2024

Adds ability to view screenshot attachments in feedbacks. The screenshot preview and modal is the same as in issues, and the code is copied over from EventTagsAndScreenshots. This will be modified when user feedback is revamped.

Screenshot in feedback item:
image

Clicking on view screenshot:
image

Relates to: #63749

@c298lee c298lee requested a review from a team as a code owner March 7, 2024 18:50
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 7, 2024
@c298lee c298lee requested review from a team and removed request for a team March 7, 2024 18:51
Copy link
Member

@ryan953 ryan953 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit picks, but looks good!

@c298lee c298lee merged commit 5c96e1c into master Mar 7, 2024
39 checks passed
@c298lee c298lee deleted the cl/feedback-screenshot-preview branch March 7, 2024 20:21
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants