New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(celery): Set "messaging.system" on span #3024
feat(celery): Set "messaging.system" on span #3024
Conversation
f1671f5
to
67e2531
Compare
45e8f3b
to
cd65142
Compare
55ba199
to
a09959b
Compare
events = capture_events() | ||
|
||
# Does not need to be a real URL, since we use always eager | ||
celery.conf.broker_url = f"{system}://example.com" # noqa: E231 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flake8 is giving a false positive E231 on the :
in the string when running in CI
92846d8
to
4af0ecb
Compare
@@ -28,7 +28,7 @@ def init_celery(sentry_init, request): | |||
def inner(propagate_traces=True, backend="always_eager", **kwargs): | |||
sentry_init( | |||
integrations=[CeleryIntegration(propagate_traces=propagate_traces)], | |||
**kwargs | |||
**kwargs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatter is adding this comment, and if I try to commit with the comma remove, CI fails. So I will keep it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I had that too at some point!
d5a29b9
to
df18b49
Compare
4af0ecb
to
fa16def
Compare
df18b49
to
9af5324
Compare
fa16def
to
6d791c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked for me in testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Set the "messaging.system" data on the "queue.process" span in the Celery integration. The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. Also, add tests for this feature. ref #2951
6d791c9
to
a02eb9c
Compare
9af5324
to
68332d8
Compare
a02eb9c
into
szokeasaurusrex/celery-retry-count
Depends on:
ref #2951