Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add top-level API for getting scopes #2988

Closed
wants to merge 4 commits into from

Conversation

sentrivana
Copy link
Contributor

@sentrivana sentrivana commented Apr 17, 2024

Adding get_current_scope(), get_isolation_scope() and get_global_scope() to the top-level API to make them easier to use. It'll also simplify our migration guide(s).

It's also part of the RFC and JS has it.


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana self-assigned this Apr 17, 2024
@sentrivana
Copy link
Contributor Author

Shelving this for now to keep the top level API minimal. This is something only advanced users will need to use. We can reevaluate at a later point if this should be added to the top-level API.

@sentrivana sentrivana closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant