docs: Update readme, migration guide #2754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
approved these changes
Feb 21, 2024
MIGRATION_GUIDE.md
Outdated
Comment on lines
36
to
37
| - `sentry_sdk._functools` was removed. | ||
| - A number of compatibility utilities were removed from `sentry_sdk._compat`: the constants `PY2` and `PY33`; the functions `datetime_utcnow`, `utc_from_timestamp`, `implements_str`, `contextmanager`; and the aliases `text_type`, `string_types`, `number_types`, `int_types`, `iteritems`, `binary_sequence_types`. |
There was a problem hiding this comment.
I realize these two items were here before and have just been reordered, but do we really need to mention them at all? They are private API, so we should be the only ones using them, anyways. I think we should remove them so that the migration guide only contains information which is important to users as they upgrade.
There was a problem hiding this comment.
Yeah I was being overly cautious including everything. Removed the _functools and _compat changes now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to the migration guide and readme.
/storeendpointsentry-sdk-2.0tomasterand the docs PR at roughly the same time)