-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope refactoring (merge Hubs and Scopes) #2610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 19, 2023
Closed
antonpirker
changed the title
(2) Call new scopes related API
(2) Call new scopes related API (but not calling it)
Jan 22, 2024
antonpirker
changed the title
(2) Call new scopes related API (but not calling it)
(2) Integrate new scopes related API
Jan 22, 2024
Closed
Co-authored-by: Ivana Kellyerova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the SDK to move away from the Hub and have all the functionality in the Scope. Introducing different types of scopes. This aligns the SDK with how Opentelementry (OTel) handles data bringing us closer to be 100% OTel compatible.
This change was discussed in this RFC:
getsentry/rfcs#122
There is also a small FAQ:
https://gist.github.com/mitsuhiko/1bc78d04ea7d08e5b50d27e42676db80
And a Miro board showing how the new scopes manage data:
https://miro.com/app/board/uXjVNtPiOfI=/?share_link_id=216270218892
This RP contains
Breaking changes
authenticated_userid()
in a customAuthenticationPolicy
class.propagate_hub
inThreadingIntegration()
was deprecated and renamed topropagate_scope
.Timeline