fix(profiling): Make esbuild detect node binaries with CJS require
#15056
+91
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix #15026
esbuild only loads the node binaries when they are loaded with
require()
in CJS andimport()
in ESM.By adding a build-time replacement string for rollup, we can either addrequire
orimport
depending on the build output.The first approach did not work as the the Node binaries were added to the build output but
import()
cannot load node binaries (only JS modules). Now, the returned value fromcreateRequire
is renamed torequire
to make it more obvious to e.g.esbuild
. However, currently there is no support forcreateRequire
inesbuild
: evanw/esbuild#1828For CJS, the native
require
is used and not the returned value fromcreateRequire
, as this variable would get renamed during build (e.g.require$1
) which causesesbuild
to ignore the node binaries as well.