Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow newer versions of 3rd-party dependencies of core #496

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Allow newer versions of 3rd-party dependencies of core #496

merged 1 commit into from
Mar 5, 2024

Conversation

allanlewis
Copy link
Contributor

@allanlewis allanlewis commented Mar 1, 2024 •
edited

As per the sole commit:

Commit fba3468 pinned @babel/core as a dependency. In order to allow users to deduplicate the Babel stack, this commit amends the spec to allow newer versions as well. The same change is made to other 3rd-party production dependencies, except for unplugin 1 and magic-string 2 which apparently need to be pinned.

@allanlewis allanlewis marked this pull request as ready for review March 1, 2024 12:05
@lforst
Copy link
Member

lforst commented Mar 4, 2024

Hi, thanks for the PR. Can you limit the change to @babel/core. We have found that (some) of the other dependencies need to be pinned exactly, namely unplugin. Thank you!

@allanlewis
Copy link
Contributor Author

Hi, thanks for the PR. Can you limit the change to @babel/core. We have found that (some) of the other dependencies need to be pinned exactly, namely unplugin. Thank you!

Sure, done!

allanlewis added a commit to allanlewis/sentry-javascript-bundler-plugins that referenced this pull request Mar 4, 2024
@allanlewis
chore(core): Allow newer versions of 3rd-party dependencies
4daa6fc 
Commit fba3468 pinned `@babel/core` as a dependency. In order to allow users to
deduplicate the Babel stack, this commit amends the spec to allow newer
versions as well. The same change is made to other 3rd-party production
dependencies, except for `unplugin` which apparently needs to be pinned [1].

[1]: getsentry#496 (comment)
@allanlewis
Copy link
Contributor Author

Actually I've just reverted the unplugin change, surely the others can float?

@lforst
Copy link
Member

lforst commented Mar 4, 2024

Please let's also let magic-string pinned because it is very mission critical. The other ones we can try.

@allanlewis
Copy link
Contributor Author

allanlewis commented Mar 4, 2024 •
edited

Please let's also let magic-string pinned because it is very mission critical.

Sure, will do.

@allanlewis
chore(core): Allow newer versions of 3rd-party dependencies
9a3301f 
Commit fba3468 pinned `@babel/core` as a dependency. In order to allow users to
deduplicate the Babel stack, this commit amends the spec to allow newer
versions as well. The same change is made to other 3rd-party production
dependencies, except for `unplugin` [1] and `magic-string` [2] which apparently
need to be pinned.

[1]: getsentry#496 (comment)
[2]: getsentry#496 (comment)
@allanlewis
Copy link
Contributor Author

I've reverted the change to magic-string.

@allanlewis
Copy link
Contributor Author

CI is passing - is there anything else I need to do here?

@lforst
Copy link
Member

lforst commented Mar 5, 2024

Nope all good! Thank you!

@lforst lforst merged commit 6e41b5a into getsentry:main Mar 5, 2024
16 checks passed
@allanlewis allanlewis deleted the unpin-core-deps branch March 5, 2024 09:20
@allanlewis
Copy link
Contributor Author

@lforst Thanks! Can I expect this to make its way into a release sometime soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lforst lforst lforst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@allanlewis @lforst