feat(core): Add injectRelease and uploadSourceMaps options
#190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
changed the title
lforst
changed the title
injectRelease and uploadSourceMaps options to permit disabling of either functionality
lforst
changed the title
injectRelease and uploadSourceMaps options to permit disabling of either functionalityinjectRelease and uploadSourceMaps options
lforst
approved these changes
Mar 29, 2023
|
Thank you very much for taking the time to implement this! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #186
This PR exposes two new user options:
disableReleaseInjection: if set totrue, it won't add any release information into the bundled files.disableSourceMapsUpload: if set totrue, the process to upload generated source maps to Sentry will be skipped.Tests have been updated accordingly.
Regarding
disableReleaseInjection, the proposed solution is to be "transparent" related to thetransformaction. It will simply return what was passed as input and bypass theprependstep.This may not be optimal, but I did not manage to find any less intrusive solution, as completely disabling the transformation seem to also disable the rest of the process, which may still be desired.